[closed] Google Analytics plugin prevents site from starting

seancoyne · October 2, 2015, 4:13pm

Recent commits against the GA plugin prevents my site from starting. Tracked this down to line 146 of the googleOAuthToken formtool:

github.com

farcrycore/plugin-googleanalytics/blob/master/packages/formtools/googleOAuthToken.cfc#L146




	<cffunction name="getRedirectURL" access="public" output="false" returntype="string">
		<cfargument name="typename" required="true" type="string" hint="The name of the type that this field is part of.">
		<cfargument name="stObject" required="true" type="struct" hint="The object of the record that this field is part of.">
		<cfargument name="stMetadata" required="true" type="struct" hint="This is the metadata that is either setup as part of the type.cfc or overridden when calling ft:object by using the stMetadata argument.">
		<cfargument name="fieldname" required="true" type="string" hint="This is the name that will be used for the form field. It includes the prefix that will be used by ft:processform.">


		<cfset var protocol = "http" />
		<cfset var domain = cgi.http_host />
		
		<cfreturn protocol & "://" & domain & "/webtop/facade/ftajax.cfm?formtool=googleOAuthToken&typename=#arguments.typename#&fieldname=&property=#arguments.stMetadata.name#&googleendpoint=1" />
	</cffunction>


	<cffunction name="getRedirectHTML" access="public" output="false" returntype="string">
		<cfargument name="typename" required="true" type="string" hint="The name of the type that this field is part of.">
		<cfargument name="stObject" required="true" type="struct" hint="The object of the record that this field is part of.">
		<cfargument name="stMetadata" required="true" type="struct" hint="This is the metadata that is either setup as part of the type.cfc or overridden when calling ft:object by using the stMetadata argument.">
		<cfargument name="fieldname" required="true" type="string" hint="This is the name that will be used for the form field. It includes the prefix that will be used by ft:processform.">


		<cfset var html = "" />
		<cfset var redirectURL = getRedirectURL(argumentCollection=arguments) />

Note the <cfreturn redirectURL = ... >

It would appear, at least on CF 10 you cannot set a variable in the cfreturn statement.

I’m getting the error:
Error instantiating farcry.plugins.googleanalytics.packages.formtools.googleOAuthToken: Invalid CFML construct found on line 146 at column 39. ColdFusion was looking at the following text:<p>=</p><p>The CFML compiler was processing:<ul><li>A cfreturn tag beginning on line 146, column 18.<li>A cfreturn tag beginning on line 146, column 18.</ul>

Removing the variable assignment (which appears unnecessary anyway) fixes the issue.

EDIT: Spoke too soon. also an issue here:

github.com

farcrycore/plugin-googleanalytics/blob/master/packages/rules/rulePopularContent.cfc#L28




	
	<cffunction name="getContentTypes" access="public" output="false" returntype="query" hint="Returns a list of potential content types">
		<cfset var result = querynew("value,name") />
		<cfset var typename = "" />
		
		<cfset queryaddrow(result) />
		<cfset querysetcell(result,"value","") />
		<cfset querysetcell(result,"name","-- All Content Types --") />
		
		<cfloop collection="#application.stCOAPI#" item="typename">
			<cfif not application.fapi.getContentTypeMetadata(typename, "bSystem", false) and application.fapi.getContentTypeMetadata(typename, "displayname", "") neq "">
				<cfset queryaddrow(result) />
				<cfset querysetcell(result, "value", typename) />
				<cfset querysetcell(result, "name", application.fapi.getContentTypeMetadata(typename, "displayname", "")) />
			</cfif>
		</cfloop>
		
		<cfquery dbtype="query" name="result">
			select		*
			from		result

you can’t have a cfloop over a collection and use index. You need to use item.

Can we get Blair to fix this?

Thanks

seancoyne · October 2, 2015, 4:24pm

I sent a pull request on github.

github.com/farcrycore/plugin-googleanalytics

fix some invalid CFML

farcrycore:master ← seancoyne:master

opened 04:19PM - 02 Oct 15 UTC

seancoyne

+94 -94

Fixes bugs I discuss here: http://discourse.farcrycore.org/t/google-analytics-pl…ugin-prevents-site-from-starting/475 Sorry about the white space changes in the rules. If you want me to fix I can probably set them back to Windows line endings, but really, you should configure your git client to commit unix endings even if you use windows line endings (autocrlf).