[closed] Google Analytics plugin prevents site from starting


Recent commits against the GA plugin prevents my site from starting. Tracked this down to line 146 of the googleOAuthToken formtool:

Note the <cfreturn redirectURL = ... >

It would appear, at least on CF 10 you cannot set a variable in the cfreturn statement.

I’m getting the error:
Error instantiating farcry.plugins.googleanalytics.packages.formtools.googleOAuthToken: Invalid CFML construct found on line 146 at column 39. ColdFusion was looking at the following text:<p>=</p><p>The CFML compiler was processing:<ul><li>A cfreturn tag beginning on line 146, column 18.<li>A cfreturn tag beginning on line 146, column 18.</ul>

Removing the variable assignment (which appears unnecessary anyway) fixes the issue.

EDIT: Spoke too soon. also an issue here:

you can’t have a cfloop over a collection and use index. You need to use item.

Can we get Blair to fix this?



I sent a pull request on github.