Integer formtool - remove numberFormat() from inputs value?

jorgenskogas · October 16, 2015, 8:51am

Why does the integer formtool edit() use numberFormat()?

From https://farcry.jira.com/browse/FC-1275
‘formtool type “integer” should have numberFormat() around value’ – Matthew Bryant

github.com

farcrycore/core/blob/master/packages/formtools/integer.cfc#L24


		<cfargument name="inputClass" required="false" type="string" default="" hint="This is the class value that will be applied to the input field.">



		<cfset var html = "" />

	

		<cfparam name="arguments.stMetadata.ftClass" default="" />

		<cfparam name="arguments.stMetadata.ftStyle" default="width:50px;" />

		<cfparam name="arguments.stMetadata.ftPrefix" default="">

		<cfparam name="arguments.stMetadata.ftSuffix" default="">

	

		<cfsavecontent variable="html">

			<cfoutput><input type="text" name="#arguments.fieldname#" id="#arguments.fieldname#" value="#arguments.stMetadata.ftPrefix##numberFormat(arguments.stMetadata.value)##arguments.stMetadata.ftSuffix#" style="#arguments.stMetadata.ftstyle#" class="textInput #arguments.inputClass# #arguments.stMetadata.ftClass#" /></cfoutput>

		</cfsavecontent>

		

		<cfreturn html />

	</cffunction>





	<cffunction name="display" access="public" output="false" returntype="string" hint="This will return a string of formatted HTML text to display.">

		<cfargument name="typename" required="true" type="string" hint="The name of the type that this field is part of." />

		<cfargument name="stObject" required="true" type="struct" hint="The object of the record that this field is part of." />

		<cfargument name="stMetadata" required="true" type="struct" hint="This is the metadata that is either setup as part of the type.cfc or overridden when calling ft:object by using the stMetadata argument." />

Shouldn’t integers always be displayed without any formatting/separators? When formatting/separators are needed we have the numeric formtool. I also think that ftPrefix and ftSuffix should be removed from the input value.

justincarter · October 18, 2015, 10:41pm

The formatting should be optional and off by default I think – I have the same issue with the separators

The prefix and suffix might be okay to leave as an option, particularly for backwards compatibility. I think the formtool already checks the value and then strips the prefix and suffix before trying to save to the DB.