Not sure how long this has been a problem (I don’t normally do the content approvals) but noticed that the emails being sent out from FarCry to content approvers contain broken links. The main issue is that the objectid is being wrapped which breaks it. e.g.
I found that in /packages/lib/email.cfc it explicitly sets the wrap to 74 characters – why is that?
Also, as email.cfc supports sending HTML emails is it worth looking at updating the calls from /packages/farcry/versioning.cfc to send as HTML rather than the default plain text? Maybe a configurable option in the webtop?
I’m having a look at this. Regarding the 74 characters - this is a typical
convention for plain text emails (though the exact number can vary from
system to system) to leave space for a few rounds of quoting.
I have updated the emails to include an HTML version (FC-3006 https://farcry.jira.com/browse/FC-3006). While I was in there I also
fixed the links so that they use:
the General Configuration “Admin Server” setting
the Environment Configuration Canonical Protocol and Canonical Domain
and finally falls back to http://#cgi.http_host# if those aren’t set
I don’t think so - 4 is the comment, 5 is the approval link. 545-549 are
setting the domain part, and 550-554 are setting the webtop location. You
can see how the values are used in the email content (556-566) - the {n}
values correspond to the values in the array.
I guess I better take a better look at what is going on Just the emails to say content has been sent back to draft don’t contain a valid URL. The link in the email starts with /index.cfm rather than protocol and domain.
I’ll do some testing tonight when I’m finished with my meetings.
There was an issue with the way the environment settings were being
retrieved, that could have caused the domain to go missing. I’ve pushed a
fix for that.
